Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use TLN prefix #20

Merged
merged 1 commit into from
Nov 3, 2023
Merged

ENH Use TLN prefix #20

merged 1 commit into from
Nov 3, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Nov 2, 2023
Closed
4 tasks
GuySartorelli
GuySartorelli requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targetting the wrong branch - there's a 1.1 branch.

@emteknetnz emteknetnz changed the base branch from 1.0 to 1.1 November 3, 2023 00:48
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit b0fb2dc into silverstripe:1.1 Nov 3, 2023
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/1.0/prefix branch November 3, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli