Revert "ENH Process modules one at a time" #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 255e75a.
emteknetnz
approved these changes
May 7, 2024
|
@GuySartorelli Could you please do a merge-up to confirm things go as planned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 255e75a.
It turns out we actually fixed this bug twice, in two different ways. This was the more complex way so I've opted to revert it in favour of the simpler way.
The simpler way was done in #25. It was merged into the
1.1branch but we didn't tag it for some reason. But I just used it and it works perfectly. I've tagged it now as1.1.6.There are merge conflicts now between
1.1and1. Those merge conflicts won't exist after this has been reverted, and then we can merge1.1with the simpler fix into1and call it a day.This repo is being added to module-standardiser as part of silverstripe/.github#237 so merge-ups and other automated workflows will be added at that time.
Issue