Skip to content

Commit

Permalink
Merge pull request #92 from creative-commoners/pulls/3.1/remove-todo
Browse files Browse the repository at this point in the history
MNT Remove TODO comments
  • Loading branch information
GuySartorelli authored Oct 19, 2023
2 parents 9b688ad + 58e03f8 commit c19d901
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/VersionFeed.php
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ public function updateSettingsFields(FieldList $fields)

public function getSiteRSSLink()
{
// TODO: This link should be from the homepage, not this page.
if (Config::inst()->get(get_class(), 'allchanges_enabled')
&& SiteConfig::current_site_config()->AllChangesEnabled
) {
Expand Down
4 changes: 2 additions & 2 deletions tests/VersionFeedFunctionalTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public function testChangesActionContainsChangesForCurrentPageOnly()
$titles = array_map(function ($item) {
return (string)$item->title;
}, $xml->xpath('//item') ?? []);
// TODO Unclear if this should contain the original version

$this->assertContains('Changed: Page1', $titles);
$this->assertNotContains('Changed: Page2', $titles);

Expand All @@ -184,7 +184,7 @@ public function testChangesActionContainsChangesForCurrentPageOnly()
$titles = array_map(function ($item) {
return (string)$item->title;
}, $xml->xpath('//item') ?? []);
// TODO Unclear if this should contain the original version

$this->assertNotContains('Changed: Page1', $titles);
$this->assertContains('Changed: Page2', $titles);
}
Expand Down

0 comments on commit c19d901

Please sign in to comment.