Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH New method to get metadata without a network request #43

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 17, 2024

Issue silverstripe/silverstripe-framework#11428

Manually tag 1.1.0 after merging

README.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/main/readme branch 2 times, most recently from 1022562 to 513f3b1 Compare October 17, 2024 22:52
@emteknetnz emteknetnz changed the title DOC Update readme ENH Add param to not make network request Oct 17, 2024
@emteknetnz emteknetnz force-pushed the pulls/main/readme branch 2 times, most recently from bb9ca4d to 4b5ecfa Compare October 17, 2024 23:01
@emteknetnz emteknetnz changed the title ENH Add param to not make network request ENH New method to get metadata without a network request Oct 17, 2024
src/MetaData.php Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 5a8cffe into silverstripe:main Oct 21, 2024
7 checks passed
@GuySartorelli GuySartorelli deleted the pulls/main/readme branch October 21, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants