Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sbatch script as close as possible as the default one #86

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Make sbatch script as close as possible as the default one #86

merged 2 commits into from
Jan 31, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Jan 30, 2023

This PR aims at using a batch script closer to the default one.

The batch script used in this PR is the same as the proposed changes in PR jupyterhub/batchspawner#258.

Related to #81

@t20100 t20100 marked this pull request as ready for review January 30, 2023 15:57
@t20100 t20100 requested a review from loichuder January 30, 2023 15:57
@t20100 t20100 added this to the Next release milestone Jan 30, 2023
loichuder
loichuder approved these changes Jan 31, 2023
View reviewed changes
jupyterhub_moss/spawner.py Outdated Show resolved Hide resolved
t20100
t20100 commented Jan 31, 2023
View reviewed changes
jupyterhub_moss/spawner.py Outdated Show resolved Hide resolved
@t20100 @loichuder
rename is_output to has_output
b4f831f 
Co-authored-by: Loïc Huder <42204205+loichuder@users.noreply.github.com>
@t20100 t20100 merged commit 08ea294 into main Jan 31, 2023
@t20100 t20100 deleted the update-sbatch-script branch January 31, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @loichuder