Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Psr\Http\Message\StreamFactoryInterface not Nyholm\Psr7\Stream #72

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

BrianHenryIE
Copy link
Contributor

Fix #70.

Added some tests too.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +26.53% 🎉

Comparison is base (72de5b4) 0.00% compared to head (33fac93) 26.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #72       +/-   ##
=============================================
+ Coverage      0.00%   26.53%   +26.53%     
=============================================
  Files             4        4               
  Lines            49       49               
=============================================
+ Hits              0       13       +13     
+ Misses           49       36       -13     
Files Changed Coverage Δ
src/HttpJsonRpcRequestFactory.php 56.52% <50.00%> (+56.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simPod simPod merged commit 6395887 into simPod:master Aug 31, 2023
10 checks passed
@@ -12,13 +12,12 @@
},
"autoload-dev": {
"psr-4": {
"SimPod\\JsonRpc\\tests\\": "tests"
"SimPod\\JsonRpc\\": "tests"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why do you prefer such change? I'm used to having NS structured as SimPod\JsonRpc\Tests\

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guy who wrote PHPUnit does not add \Tests\ to the namespace.

https://github.com/sebastianbergmann/uuid/blob/main/tests/UuidTest.php

Sorry I can’t find (on mobile) a more definitive statement from him.

I don’t see any advantage to adding the \Tests\ part of the namespace. It complicates things by needing imports that are otherwise inherent. I think the fact it’s autoload-dev is sufficient distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nyholm/psr7 dependency
2 participants