Fixed calculation of profit when closing deals

simba77 · Aug 22, 2024 · f8ae511 · f8ae511
1 parent a7ab652
commit f8ae511
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/Services/Deals/DealService.php b/src/Services/Deals/DealService.php
@@ -227,9 +227,16 @@ private function getDealSum(SecurityDTO $securityDTO, SellDealRequestDTO $dealRe
             $result = bcmul($result, (string) $dealRequestDTO->quantity, 4);
             return bcadd($result, bcmul($securityDTO->bondAccumulatedCoupon, (string) $dealRequestDTO->quantity, 4), 4);
         } elseif ($securityDTO->securityType === SecurityTypeEnum::Future) {
-            $result = bcmul($securityDTO->lotSize, $dealRequestDTO->price, 4);
-            $result = bcmul($result, (string) $dealRequestDTO->quantity, 4);
-            return bcsub($result, bcmul(bcmul($deal->getBuyPrice(), $securityDTO->lotSize, 4), (string) $dealRequestDTO->quantity, 4));
+            if ($securityDTO->lotSize < $dealRequestDTO->price) {
+                $sellLotPrice = $dealRequestDTO->price;
+                $buyLotPrice = $deal->getBuyPrice();
+            } else {
+                $sellLotPrice = bcmul($securityDTO->lotSize, $dealRequestDTO->price, 4);
+                $buyLotPrice = bcmul($deal->getBuyPrice(), $securityDTO->lotSize, 4);
+            }
+            $sellFullPrice = bcmul($sellLotPrice, (string) $dealRequestDTO->quantity, 4);
+            $buyFullPrice = bcmul($buyLotPrice, (string) $dealRequestDTO->quantity, 4);
+            return bcsub($sellFullPrice, $buyFullPrice);
         }
         return '0';
     }