Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextPainter leaking #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TextPainter leaking #149

wants to merge 1 commit into from
+52 −4

Conversation

tmpsantos
Copy link

@tmpsantos tmpsantos commented Oct 2, 2024 •
edited
Loading

Dispose it when it is no longer in use.

Also add leak detection to all the unit tests to prevent regressions.

Fixes #150

@tmpsantos
Fix TextPainter leaking
b537868 
Dispose it when it is no longer in use.

Also add leak detection to all the unit tests to prevent regressions.
@tmpsantos
Copy link
Author

Removing both dispose() will make the tests fails with the leak error.

@tmpsantos tmpsantos mentioned this pull request Oct 2, 2024
Open
@tmpsantos
Copy link
Author

@simc do you have any feedback on this PR?

@Nana-Kwame-bot
Copy link

Is this going to be merged ever?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak on TextPainter
2 participants
@tmpsantos @Nana-Kwame-bot