-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new layout bare-wide #2253
Draft
thielema
wants to merge
1
commit into
simonmichael:master
Choose a base branch
from
thielema:layout-bare-wide
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
new layout bare-wide #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thielema
force-pushed
the
layout-bare-wide
branch
2 times, most recently
from
October 9, 2024 10:02
a2799a0
to
a5c83ac
Compare
Interesting! I will try to use it, when it can also display the date headings again. (Perhaps this PR should be marked draft.) |
I don't remember what that TODO comment was about, we can drop it. |
On Wed, 9 Oct 2024, Simon Michael wrote:
Interesting! I will try to use it, when it can also display the date
headings again. (Perhaps this PR should be marked draft.)
yes, currently it is a draft
|
thielema
force-pushed
the
layout-bare-wide
branch
from
October 9, 2024 19:10
a5c83ac
to
c954353
Compare
(I was seeing the green Open badge on github. I have changed the status to Draft so I don't accidentally merge too soon..) |
On Wed, 9 Oct 2024, Simon Michael wrote:
Interesting! I will try to use it, when it can also display the date headings again.
hledger -f hledger-journal balance --yearly --layout=bare-wide --output-file=multibalance.html
This shows date headings. Or what do you mean?
|
Message ID: ***@***.***>Ah, I was testing terminal output. No date headings there.
|
On Wed, 9 Oct 2024, Simon Michael wrote:
Ah, I was testing terminal output. No date headings there.
Text output does not support the new layout for now, because this would
require a Table type that allows to give labels to Header groups. (I have
a draft for such an alternative Table type, though.)
|
It is affected by --layout=bare-wide though, just FYI.
|
thielema
force-pushed
the
layout-bare-wide
branch
12 times, most recently
from
October 18, 2024 17:03
13cec57
to
5d02eaf
Compare
thielema
force-pushed
the
layout-bare-wide
branch
3 times, most recently
from
October 24, 2024 07:59
bbc178b
to
17ae71f
Compare
thielema
force-pushed
the
layout-bare-wide
branch
from
November 9, 2024 07:41
17ae71f
to
e8ab077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for a new type of layout. This is the original reason why I started to work on hledger export functions ...
I called it
bare-wide
, because it is likebare
but the amounts are put in one column per commodity. Sometimes it requires two header rows and horizontally merged headers for dates. I implemented it for HTML and FODS output of plain balance, multi-period balance and compound balances. Not implemented for budget reports, but those reports support only bare and non-bare layouts, anyway.I thought about alternative names like
sub
(one sub-column per commodity),columns
,separate
. Maybe you have better ideas.I have also some draft code for a table type with labels for header groups. This could enable layout bare-wide for the text outputs. This draft code is not contained in this pull request.
I found a command in
multiBalanceReportHtmlRows
that reads:I do not know whether it is still relevant. I have moved it to
compoundBalanceReportAsHtml
but it might be even more confusing there.