lib: fix division by zero in roi when all assets are sold (fixes #2281) #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonmichael I dont understand the CI run failure here, but I think it is unrelated to my change |
|
Yes, CI failure caused by recent hackage outage I guess. Thanks for the fix. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TWR computation works by computing the running total of "investment units" and their cost. If at some point we run out of units, we could divide by zero trying to compute new cost. Instead lets just reset the cost the the initial one as we have essentially went to the initial state (no units on hand, cost is an arbitrary chosen number 100).
This fixes #2281