Indian tree presets #407
Merged
Indian tree presets #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpoole
requested changes
Oct 21, 2023
There was a problem hiding this comment.
As already pointed out, the PR/commits need to be rebased on master so that I can cleanly merge them. If you can't or don't want to do that (you should however learn it as it is an essential step in contributing to FOSS projects these days), be sure to allow me to push to the PR and I'll do it before merging.
2nd point (didn't originally notice this, sorry) the denotation combo is being repeated as are other "standard" tree attributes, these should be moved in to a chunk (insert it after the "leaf" chunk.
simonpoole
force-pushed
the
indian-tree-presets
branch
from
486ef87 to
f160ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.