Improved song matching, other updates #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted search string to include artist - Added similarity factor to song and artist - Added exact, secondary, fizzy match outcomes - Debug parameter to check secondary, fuzzy matches - Added exception handling for KeyError (nothing returned from Apple web service)
|
Tested, works nicely. When searching for FAILed songs, I noticed that the song was found manually by leaving out commas, symbols like & and the word "remix" or "edit". |
|
Could you open a separate filestream to solve #19? |
|
Shouldnt be a problem, Ill have a look at this next week! |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original script was returning a lot of incorrect matches, so added the following:
web service)