Refactor CLI components #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
plaplant
reviewed
Jan 24, 2024
| type=str, | ||
| nargs="+", | ||
| help="key-value pairs of events.", | ||
| ) | ||
| sp.set_defaults(func=add_file_event) |
There was a problem hiding this comment.
After writing this submodule, it has since struck me as odd that I decided to put the target function definitions after they are specified here. (I tend to write code so that functions are defined before they are used, though obviously this is not strictly required.) Refactoring so the functions (like add_file_event) come before the subparser definitions has never been a high priority, but now that we're significantly editing this file, I think I'd prefer to move the subparser definitions to be below the target function definitions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI components have been re-factored and we now load all settings from a standard
pydanticBaseSettingsso they can be configured using environment variables.