Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SneakerNet Required Changes #47

Merged
merged 36 commits into from
Mar 5, 2024
Merged

SneakerNet Required Changes #47

merged 36 commits into from
Mar 5, 2024

Conversation

JBorrow
Copy link
Member

@JBorrow JBorrow commented Feb 26, 2024

Includes all the changes required for SneakerNet functionality.

@JBorrow JBorrow added this to the Sneaker Net milestone Feb 26, 2024
@JBorrow JBorrow changed the base branch from main to librarian-v2 February 26, 2024 20:02
@JBorrow
Copy link
Member Author

JBorrow commented Feb 28, 2024

Need to think about the callback system. I think we can have downstream callback to site and create remote instance at that time (to avoid 'fake' remote instances that do not yet exist). But need to think about ordering in sync tasks, as they assume 'does not have remote instance' means 'still needs to be transferred'. That's not compatible with our async methodolgy.

@JBorrow
Copy link
Member Author

JBorrow commented Mar 1, 2024

Need to figure out why the librarian instances aren't ingesting their new 'name field.

@JBorrow JBorrow mentioned this pull request Mar 1, 2024
@JBorrow JBorrow mentioned this pull request Mar 1, 2024
@JBorrow
Copy link
Member Author

JBorrow commented Mar 1, 2024

To be done:

@JBorrow JBorrow marked this pull request as ready for review March 5, 2024 13:35
@JBorrow JBorrow merged commit 1ae236c into librarian-v2 Mar 5, 2024
5 checks passed
@JBorrow JBorrow deleted the sneaker-net branch March 5, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant