Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-monitor: Fix conifg examples and add to plugin file #811

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented Jan 6, 2025

Description

This makes the naming convention between the instance-id and docker compose service name consistent, which host mangers need. It also adds the explicit port mapping, which the agent needs as data gets sent to it from another device, rather than it reaching out to the device (which would require the 'host' network mode.)

We also add the agent to the plugin file so it can be launched by ocs-agent-cli.

Motivation and Context

Noticed these while deploying the agent on site.

How Has This Been Tested?

Largely tested on site. The plugin part hasn't been tested yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This makes the naming convention between the instance-id and docker compose
service name consistent, which host mangers need. It also adds the explicit
port mapping, which the agent needs as data gets sent to it from another
device, rather than it reaching out to the device (which would require the
'host' network mode.)
@BrianJKoopman BrianJKoopman marked this pull request as ready for review January 6, 2025 18:14
@BrianJKoopman BrianJKoopman changed the title ld-monitor: Fix configuration file examples ld-monitor: Fix configuration file examples and add to plugin.py Jan 6, 2025
@BrianJKoopman BrianJKoopman changed the title ld-monitor: Fix configuration file examples and add to plugin.py ld-monitor: Fix conifg examples and add to plugin file Jan 6, 2025
@BrianJKoopman BrianJKoopman merged commit 6c4c73e into main Jan 6, 2025
6 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/ld-monitor-docs-updates branch January 6, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant