Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js 20 #2

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Use Node.js 20 #2

merged 3 commits into from
Mar 13, 2024

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Mar 13, 2024

Changes

  • Upgrade GitHub Actions runtime to Node.js 20
  • Upgrade labeler runtime to Node.js 20
  • Use latest npm lockfile version

Files are auto-formatted by Prettier.

I intentionally didn't update dist. We could update dist on the version release rather than on every commit/PR.

@LitoMore LitoMore added the meta Issues or pull requests regarding the project or repository itself label Mar 13, 2024
@LitoMore LitoMore requested a review from mondeja March 13, 2024 03:47
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally didn't update dist. We could update dist on the version release rather than on every commit/PR.

I think that is better to update on pre-commit with Husky and add the dist/ folder to .gitattributes with -diff option because in the future we'll forget about that.

action.yml Outdated Show resolved Hide resolved
@LitoMore LitoMore requested a review from mondeja March 13, 2024 05:27
@LitoMore
Copy link
Member Author

I think that is better to update on pre-commit with Husky and add the dist/ folder to .gitattributes with -diff option because in the future we'll forget about that.

We can do it on another PR.

In the meantime, we can add an action to check if we forgot to update the dist.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, we can add an action to check if we forgot to update the dist.

This seems to be much more work. No problem, I'll add it in another PR.

@mondeja mondeja merged commit 6273151 into main Mar 13, 2024
4 checks passed
@mondeja mondeja deleted the node-20 branch March 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants