Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sudo to Docker commands in README #2351

Closed
wants to merge 1 commit into from

Conversation

wikmor
Copy link

@wikmor wikmor commented Dec 26, 2024

Ensure the commands work for all users, including those who haven’t configured Docker for non-sudo access.

Ensure the commands work for all users, including those who haven’t configured Docker for non-sudo access.
@cquintana92
Copy link
Collaborator

Hi! Thanks for your suggestion.

However, I'm not too keen on adding sudo to all docker commands, as It's up to the user to set up proper docker usage/access permissions on their hosts.

If you have your used added to the docker group (as it's recommended, only to grant execution permissions on the docker CLI, and not on the whole system), then you don't need sudo to run docker. Root should only be needed to add yourself to the docker group.
In environments where the user executing these commands are not the system owner / root user, they wouldn't be able to run the commands with sudo, but the root owner / sysadmin can add the user to the docker group and the commands should work as they were written before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants