New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to sensor #337

Merged

runger1101001 merged 2 commits into simplefoc:dev from runger1101001:dev

Nov 7, 2023

Member

runger1101001 commented Nov 7, 2023

Check that returned angles from subclasses getSensorAngle() calls are non-negative

This allows a sensor driver to not return an angle in the case of failed CRC checks, etc by returning a negative value
Part of improvement #334

Remove warnings in Commander about using Strings as char* by changing type to const char* and casting to char* elsewhere

Richard Unger added 2 commits

November 8, 2023 00:18


          fix const char warnings

7b336cf


          check returned sensor angle is non-negative

9fd6621

runger1101001 merged commit 639ccab into simplefoc:dev

16 checks passed

runger1101001 added this to the 2.3.2_Release milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet