Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bugs in B-G431-ESC1 example #343

Closed
wants to merge 1 commit into from

Conversation

zhangyq-227
Copy link

Hi, I find some bugs in B-G432B-ESC1 example when I test.

  1. In the loop function, we need a loopFOC() function to start the motor.
  2. build_opt.h file need to add "lib_archive=false" to compile correctly in platformIO.
    All changes are verified on my real hardware.
    I‘m sorry, My English is not very good. I look forward to your reply.
    Wish you a happy life.

@runger1101001
Copy link
Member

Thank you very much for reporting this! Your English is just fine, I understand you perfectly.

@runger1101001 runger1101001 changed the base branch from master to dev November 28, 2023 21:44
@runger1101001 runger1101001 self-assigned this Nov 28, 2023
@runger1101001 runger1101001 added the bug Something isn't working label Nov 28, 2023
@runger1101001
Copy link
Member

I've changed this PR from main to dev branch, we only accept changes to the dev branch.

However, there are also some compilation problems with this PR - I think it doesn't like the lib_archive=false in the build_opts file. Normally this option should be put in your platformio.ini file...

Also your changes to the example file include changing the sensor type, using current sensing, etc... so I think we should restrict the changes just to the bug itself, if possible.

I think if it is ok with you and to save you further work I will manually introduce just the change with the missing loopFOC() in a separate commit.

@runger1101001
Copy link
Member

Done, in this PR: #349

@runger1101001 runger1101001 added this to the 2.3.2_Release milestone Nov 28, 2023
@zhangyq-227 zhangyq-227 deleted the update branch November 29, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants