Add support for parallel deployment #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you either break it up into two commits or make the commit message with shorter title and a description? |
mosabua
reviewed
Oct 28, 2024
...n-repository-provisioner/src/main/java/com/simpligility/maven/provisioner/Configuration.java
Outdated
Show resolved
Hide resolved
dakaneye
force-pushed
the
update-maven-resolver-vesion
branch
from
62be452
to
c9d87d3
Compare
dakaneye
changed the title
shortened a bit! Let me know if that's alright. |
mosabua
requested changes
Oct 29, 2024
...n-repository-provisioner/src/main/java/com/simpligility/maven/provisioner/Configuration.java
Outdated
Show resolved
Hide resolved
...n-repository-provisioner/src/main/java/com/simpligility/maven/provisioner/Configuration.java
Outdated
Show resolved
Hide resolved
...n-repository-provisioner/src/main/java/com/simpligility/maven/provisioner/Configuration.java
Outdated
Show resolved
Hide resolved
...ry-provisioner/src/main/java/com/simpligility/maven/provisioner/MavenRepositoryDeployer.java
Outdated
Show resolved
Hide resolved
mosabua
changed the title
dakaneye
force-pushed
the
update-maven-resolver-vesion
branch
from
c9d87d3
to
7a2644e
Compare
Includes the required update for maven resolver and two new configuration properties to enable parallel deployment and configure parallelism. Signed-off-by: Samuel Dacanay <sam.dacanay@chainguard.dev>
By passing Configuration in and storing as a class variable, we can ensure that the params provided to Deployer dont continue to expand. It simplifies the method signatures too. Signed-off-by: Samuel Dacanay <sam.dacanay@chainguard.dev>
dakaneye
force-pushed
the
update-maven-resolver-vesion
branch
from
7a2644e
to
b93f4f4
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the maven resolver version to 1.9.22 so we can support parallelizatin of the deploy. Then, set the appropriate configuration property on the session to allow for parallel deploy.
References: