Skip to content

Commit

Permalink
fix failing caching-node connect (#66)
Browse files Browse the repository at this point in the history
* added support for caching-node connect

* fixed codeQL error

* fixed codeQL error

* fixed codeQL error

* updated caching-node connect param

* updated caching-node connect param

* updated caching-node connect param

* fixed codeQL error

* fixed codeQL error

* commented out code blocks

* fixed codeQL error

* reverted changes and updated helm chart

* reverted changes and updated helm chart

* reverted changes and updated helm chart
  • Loading branch information
geoffrey1330 authored Aug 22, 2024
1 parent 6685c3d commit 9a74931
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions charts/latest/spdk-csi/templates/caching-node-handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ spec:
value: "{{ .Values.cachingnode.cpuMask }}"
- name: SPDKMEM
value: "{{ .Values.cachingnode.spdkMem }}"
- name: SPDKIMAGE
value: "{{ .Values.image.spdk.repository }}:{{ .Values.image.spdk.tag }}"
# - name: SPDKIMAGE
# value: "{{ .Values.image.spdk.repository }}:{{ .Values.image.spdk.tag }}"
- name: S3DATAPATH
value: "{{ .Values.cachingnode.s3DataPath }}"
- name: BLOCKEDPCIE
Expand Down
4 changes: 2 additions & 2 deletions charts/latest/spdk-csi/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ cachingnode:
s3DataPath: /dev/nvme2n1
blockedPcie: 0000:00:1e.0
ftlBufferSize: 10g
lvStoreClusterSize: 4M
lvStoreClusterSize: 4194304
initialStoreSize: 1T
numPagesPerClusterRatio:
numPagesPerClusterRatio: 25
s3BucketName:
2 changes: 1 addition & 1 deletion e2e/templates/pvc-cache.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: spdkcsi-cache-pvc3
name: spdkcsi-cache-pvc
annotations:
simplybk/secret-name: simplyblock-pvc-keys
simplybk/secret-namespace: default
Expand Down
2 changes: 1 addition & 1 deletion e2e/templates/testpod-cache.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: spdkcsi-cache-test
spec:
nodeSelector:
type: cache
type: simplyblock-cache
containers:
- name: alpine
image: alpine:3
Expand Down

0 comments on commit 9a74931

Please sign in to comment.