Workflow dispatch #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Authenticate with Kubernetes cluster | ||
| run: | | ||
| mkdir -p "${HOME}/.kube" | ||
| echo ${{ secrets.KUBE_CONFIG_DATA }} | base64 --decode > ${HOME}/.kube/config |
There was a problem hiding this comment.
kubeconfig data also changes for a new cluster. You might also have to take kubeconfig from the workflow dispatch.
There was a problem hiding this comment.
I think leaving it as a secret is much better as it needs to be treated as one.
It is easily updated by changing the secret value with the new kubeconfig
There was a problem hiding this comment.
don't we have to update the secret every time you run the e2e tests?
There was a problem hiding this comment.
No we don't.
we only update it if the cluster we are testing on changes.
boddumanohar
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.