Implement a strawman version of Ret Aura #7418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They do seem to have added some form of debuff decay here - I'm not yet sure how it works |
|
I think with the removal of Retribution Aura, we can close this PR, since it's no longer needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less the thing lightly mentioned in Discord, though I haven't touched the core global buffs before so figure it's worth getting feedback.
The approach here is that every player will, once a second, roll for whether ret aura procced that second or not - and we can customize the roll probability. 15% was completely arbitrarily chosen; we could pick a real estimated value to approximate what logs estimate the uptime to be - or we could just not have this proc at all by default, since (unlike the personal Retribution Aura from 10.0.0) it seems unlikely that it will meaningfully affect character optimization choices and may be less misleading than assuming a high uptime.
What do y'all think? Do we bother with this?