[shaman] Misc Lightning Rod / Conductive Energy fixes #9723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change seeks to correct some bugged behavior in sims with regards to Lightning Rod (the talent), Lightning Rod (the debuff), and Conductive Energy (the talent). For Enhancement, Conductive Energy makes Elemental Blast, Lightning Bolt, Chain Lightning, and Tempest all apply Lightning Rod (the debuff) whilst not having Lightning Rod (the talent). For Elemental, Conductive Energy makes Tempest damage accumulate into Lightning Rod (the debuff) and makes Tempest also apply the Lightning Rod (debuff) regardless of whether or not the Lightning Rod (talent) is taken, based on tooltips and in-game testing. Additionally for Elemental, the spells Elemental Blast, Earthquake, and Earth Shock only should proc Lightning Rod (the debuff) IFF Lightning Rod (the talent) is selected. simc was exhibiting the following behavior instead: * Elemental Shaman Elemental Blasts (any variant!) were proc'ing Lightning Rod if Lightning Rod OR Conductive Energy were talented (wrong!) * Elemental Shaman Tempest's were only proc'ing Lightning Rod if both the Lightning Rod talent and the Conductive Energy talent were taken (wrong!)
|
Additional finding:
|
Previously, Elemental Lightning Bolt was only accumulating into Lightning Rod (the debuff) if Lightning Rod (the talent) was taken. This is incorrect, and Conductive Energy applied Lightning Rods should still accumulate this damage.
wfarr
force-pushed
the
fix-conductive-energy
branch
from
cadc33f
to
6847995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seeks to correct some bugged behavior in sims with regards
to Lightning Rod (the talent), Lightning Rod (the debuff), and
Conductive Energy (the talent).
For Enhancement, Conductive Energy makes Elemental Blast, Lightning
Bolt, Chain Lightning, and Tempest all apply Lightning Rod (the debuff)
whilst not having Lightning Rod (the talent).
For Elemental, Conductive Energy makes Tempest damage accumulate into
Lightning Rod (the debuff) and makes Tempest also apply the Lightning
Rod (debuff) regardless of whether or not the Lightning
Rod (talent) is taken, based on tooltips and in-game testing.
Additionally for Elemental, the spells Elemental Blast, Earthquake, and
Earth Shock only should proc Lightning Rod (the debuff) IFF Lightning
Rod (the talent) is selected.
simc was exhibiting the following behavior instead:
if Lightning Rod OR Conductive Energy were talented (wrong!)
Lightning Rod talent and the Conductive Energy talent were taken
(wrong!)