Add `Create Menu Item` Action #144

NoahKamara · 2023-08-23T17:41:58Z

Fixes #141

To Do

Create Intent Logic
Add Documentation for Shortcuts.app
Move to Intents Extension
Add to app-store-description

NoahKamara · 2023-08-23T17:44:42Z

I figured out a way to implement this without using the contact hack.
A choose from list action will by default show the DisplayRepresentation title subtitle and image so I just implemented it using that

A user can currently choose between Emoji and SF Symbol for the icon as well as apply a background and foreground (only symbol) color

@sindresorhus is there a requirement for using a single app per Action?

sindresorhus · 2023-08-23T20:50:51Z

Thanks for working on this 👍

sindresorhus · 2023-08-23T20:51:29Z

@sindresorhus is there a requirement for using a single app per Action?

By "app", do you mean "file". If so, yes, I would prefer to keep an action and related types in one file. Otherwise it simply ends up being too many files.

sindresorhus · 2023-08-23T20:51:38Z

Code should be tab-indented.

Shared/Actions/Rich Menu/Models/RMStyle.swift

Shared/Actions/Rich Menu/Models/RMShape.swift

Shared/Actions/Rich Menu/Models/RMIconContainer.swift

Shared/Actions/Rich Menu/CreateMenuItem.swift

Config.xcconfig

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

sindresorhus · 2023-08-28T00:02:59Z

You have many lint warnings. See the diff.

Shared/Actions/CreateMenuItem.swift

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

…arsed

muescha · 2023-09-02T16:11:45Z

readme should also updated at section Included actions

sindresorhus · 2023-09-03T09:06:32Z

I won't be able to try this out until Xcode 15 RC is out, probably in a week.

Actions.xcodeproj/project.pbxproj

Shared/Actions/CreateMenuItem.swift

app-store-description.txt

sindresorhus · 2023-09-14T08:58:14Z

You need to resolve the merge conflict.

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Conflicts: .gitignore Actions.xcodeproj/project.pbxproj Config.xcconfig

remove progressive disclosure in summary

Conflicts: Config.xcconfig

sindresorhus · 2023-09-28T18:09:47Z

Thanks :)

sindresorhus · 2023-09-28T19:38:17Z

Btw, this still required substantial clean up: 5455817 In case you are interested in seeing what to improve upon. It was easier to do it afterwards than to comment on everything. I also found a bunch of minor bugs. Some things here are just based on my preference though.

Add `Combine Lists` action Add `Get Music Playlists` action Add `Filter List` action Add `Truncate List` action Add `Get Emojis` action 1.2.0 Add `Send Feedback` action Add `Is Audio Playing` action Add `Is Bluetooth On` action Add `Is Dark Mode` action Add `Write or Edit Text` action Improve the welcome screen Add `Get User Details` action Add `Is Connected to VPN` action Add `Edit URL` action 1.3.0 Get `Get Title of URL` action Add `Get Battery State` action Add `Is Low Power Mode` action Use larger font size in the text editor Add `Remove Non-Printable Characters` action Add `Format Currency` action Add `Hide Shortcuts App` action Add `Get Running Apps` action Add `Spell Out Number` action 1.4.0 Add `Get Audio Playback Destination` action Add `Is Silent Mode On` action Fixes #8 Add `Haptic Feedback` action Fixes #6 Add `Get File Icon` action 1.5.0 Support non-HTTPS URLs in the "Get Title of URL" action 1.5.1 Add `Transform Lists` action (#17) Add `Truncate Text` action Add `Round Number to Multiple` action Fixes #11 Add `Create Color Image` action 1.6.0 Validate URL scheme in `Create URL` action Because Foundation throws an exception if it's invalid, which we cannot handle. Add `Is Online` action Minor tweaks Add `Geo URI` action Fixes #21 Add `Symbol Image` action 1.7.0 Fix `SymbolImage` action for larger sizes Add `Is Reachable` action Add `Parse CSV` action 1.8.0 Fix “Parse CSV” action description 1.8.1 Add `Scan QR Code from Image` action (#25) Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> Various tweaks Add `Pretty Print Dictionaries` action Add `Parse JSON5` action Add `Merge Dictionaries` action Add `Scan Documents` action Add `Format Duration` action Add `Transcribe Audio` action Add `Get Unsplash Image` action 1.9.0 Fix an issue with the “Transcribe Audio” action Add `Choose from List (Extended)` action Add `Generate CSV` action 1.10.0 Add `Is Screen Locked` action Minor tweaks Add `Is Wi-Fi On` action Fixes #33 Add `Get Related Words` action 1.11.0 Minor tweaks Add `Get Query Item Value from URL` action Fixes #36 Add `Get Query Items from URL` action Add `Get Query Items from URL as Dictionary` action Add `Get Device Orientation` action Add `Is Device Orientation` action Add `Format Number — Compact` action 1.12.0 `Transform Text`: Support transliterating text into other scripts (#42) Minor tweaks 1.13.0 Minor tweaks Fix reading QR codes from images with transparent background Fixes #47 1.13.1 Minor tweaks Rewrite the app and require macOS 13 and iOS 16 Fixes #57 Add `Format Person Name` action Add `Blur Images` action Add `Play Alert Sound` action Add `Flash Screen` action Add `Calculate with Soulver` action `Transform Text`: Add `Slugify` transformation Add `Authenticate` action Add `Convert Coordinates to Location` action Add `Get Index of List Item` action Add `Reverse Lines` action Add `Ask for Text with Timeout` action Add `Is Cellular Data On` action Add `Hex Encode` action Refactor Add `Overwrite File` action Add `Generate Random Data` action Fix macOS compatibility 2.0.0 Add back `Calculate with Soulver` action Bug fixes 2.0.1 Add `Get Map Image of Location` action Add `Get High-Resolution Timestamp` action Use extension again 2.1.0 Add `Get Random Number from Seed` action Fixes #80 Various tweaks 2.1.1 Minor tweaks 2.1.2 `Is Dark Mode On`: Fix iOS 16.2 compatibility `Ask for Text with Timeout`: Add type parameter Fixes #84 Add printer actions Fixes #48 2.2.0 Minor tweaks 2.2.1 Tweaks Fixes #104 Add `Is Host Reachable` action Fixes #58 Add `Open URLs with App` action Add `Global Variable` actions Fixes #96 2.3.0 Tweaks 2.3.1 Tweaks Fixes #122 Add `Truncate Number` action 2.4.0 Add `Set Uniform Type Identifier` action Add `Get Average Color of Image` action Add `Get Actions Version` action Tweaks Add `Ask ChatGPT` action 2.5.0 `Ask ChatGPT`: Improve error handling 2.5.1 Tweaks 2.5.2 Tweaks Add `Get Dominant Colors of Image` action `Ask ChatGPT`: Add more parameters Add `Wait Milliseconds` action 2.6.0 Tweaks Fixes #136 Add `Get Device Details (Extended)` action Tweaks Add `Invert Images` action Add `Get Boolean from Input` action Add `Is Day` action 2.7.0 Add `Get Modifier State` action Improve contributing guide Add `Boolean` action Meta tweaks Fix problem with some actions that require temporary directory Fixes #140 Meta tweaks 2.8.0 Tweaks 2.8.1 Add `Is Cellular Low Data Mode` action Fix the `Haptic Feedback` action Remove `Ask ChatGPT` action See https://sindresorhus.com/ai-actions for replacement. Add `Is Device Locked` action Tweaks 2.9.0 Add `Create Menu Item` action (#144) Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> Code style tweaks Clean up #144 Tweaks Add `Combine Videos` action Tweaks Fixes #162 Add `Is Accessibility Feature On` action Fixes #163 Tweaks Add `Color` action Add `Get Average Color` action Add `Get Image Location` action Add `Set Image Location` action Add `Is Shaking Device` action Tweaks Fixes #174 2.10.0 Add `Is Call Active` action Tweaks Add `Authenticate (New)` action Add `Get Compass Heading` action Require macOS 14 and iOS 17 Add `Is Device Moving` action Add `Get Device Motion Data` action Add `Get Bluetooth Devices` action Tweaks 3.0.0 Add `Get Elevation` action Add `Find Music Playlist` action Fixes #212 Tweaks Fixes #206 Fixes #214 3.1.0 Tweaks Add `Encrypt File` action Fixes #220 Add `Encrypt Text` action Fixes #220 Add `Is Camera On` action Add `Is Conforming to Uniform Type Identifier` action Add `Join Wi-Fi` action Fixes #223 Add `Named Clipboard` action Add `Get Sentences from Text` action Add `Get Paragraphs from Text` action Tweaks Fixes #229 Add `Is Microphone On` action Tweaks 3.2.0 Add `Is Time` action Tweaks Fixes #244 Fixes #248 3.3.0 Init

NoahKamara added 3 commits August 23, 2023 19:22

Add PRODUCT_BUNDLE_IDENTIFIER to Config

bf931a0

Add CreateMenuItem Action

9345fe8

Merge remote-tracking branch 'refs/remotes/Upstream/main'

f8ed488

NoahKamara marked this pull request as draft August 23, 2023 17:42

sindresorhus requested changes Aug 23, 2023

View reviewed changes

NoahKamara and others added 4 commits August 24, 2023 02:11

Update Shared/Actions/Rich Menu/Models/RMStyle.swift

cd84ca6

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Apply suggestions from code review

a90b90c

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Implemented Changes suggested by review

fedf7ef

linting

2d678a7

sindresorhus requested changes Aug 28, 2023

View reviewed changes

sindresorhus reviewed Aug 28, 2023

View reviewed changes

Shared/Actions/CreateMenuItem.swift Outdated Show resolved Hide resolved

sindresorhus reviewed Aug 28, 2023

View reviewed changes

Shared/Actions/CreateMenuItem.swift Outdated Show resolved Hide resolved

NoahKamara and others added 7 commits August 28, 2023 13:14

Update Shared/Actions/CreateMenuItem.swift

6242b6e

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

linting

6d963b9

applied changes requested in review

9231032

Add .DS_Store and Build folder to gitignore

acd3913

Fix CreateMenuItem.swift not appearing in file tree

ff3c4e1

Remove private access control from CreateMenuItem - intent wasnt be p…

4197150

…arsed

Add Create Menu Item to app-store-description.txt

798fb15

sindresorhus requested changes Sep 14, 2023

View reviewed changes

NoahKamara and others added 2 commits September 27, 2023 22:34

Merge remote-tracking branch 'refs/remotes/Upstream/main'

dde7d52

Update Shared/Actions/CreateMenuItem.swift

1606e2e

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

NoahKamara added 4 commits September 27, 2023 22:52

Merge branch 'main'

2f8d92d

Conflicts: .gitignore Actions.xcodeproj/project.pbxproj Config.xcconfig

Merge remote-tracking branch 'refs/remotes/origin/rich-menu'

f8090a7

add dev_team variable for DEBUG (not release)

8801e98

remove progressive disclosure in summary

add action to readme

2656d95

NoahKamara requested a review from sindresorhus September 27, 2023 21:18

NoahKamara added 2 commits September 28, 2023 10:57

Merge remote-tracking branch 'refs/remotes/Upstream/main'

deba9ba

Conflicts: Config.xcconfig

remove duplicate Build input file

379b1ff

NoahKamara marked this pull request as ready for review September 28, 2023 09:03

sindresorhus added 3 commits September 29, 2023 00:59

Update project.pbxproj

3fed939

Update project.pbxproj

6fe1f9e

Update .gitignore

d79d947

sindresorhus merged commit 5afbb75 into sindresorhus:main Sep 28, 2023
1 check passed

sindresorhus added a commit that referenced this pull request Sep 28, 2023

Clean up #144

b79a3cc

sindresorhus added a commit that referenced this pull request Sep 28, 2023

Clean up #144

5455817

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Create Menu Item` Action #144

Add `Create Menu Item` Action #144

NoahKamara commented Aug 23, 2023 •

edited

Loading

NoahKamara commented Aug 23, 2023

sindresorhus commented Aug 23, 2023

sindresorhus commented Aug 23, 2023

sindresorhus commented Aug 23, 2023

sindresorhus commented Aug 28, 2023

muescha commented Sep 2, 2023

sindresorhus commented Sep 3, 2023

sindresorhus commented Sep 14, 2023

sindresorhus commented Sep 28, 2023

sindresorhus commented Sep 28, 2023

Add Create Menu Item Action #144

Add Create Menu Item Action #144

Conversation

NoahKamara commented Aug 23, 2023 • edited Loading

To Do

NoahKamara commented Aug 23, 2023

sindresorhus commented Aug 23, 2023

sindresorhus commented Aug 23, 2023

sindresorhus commented Aug 23, 2023

sindresorhus commented Aug 28, 2023

muescha commented Sep 2, 2023

sindresorhus commented Sep 3, 2023

sindresorhus commented Sep 14, 2023

sindresorhus commented Sep 28, 2023

sindresorhus commented Sep 28, 2023

Add `Create Menu Item` Action #144

Add `Create Menu Item` Action #144

NoahKamara commented Aug 23, 2023 •

edited

Loading