Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to maintained successor for PHP #2846

Closed
wants to merge 1 commit into from

Conversation

dereuromark
Copy link

Previous one is not maintained anymore.
So taking over as a group effort from now on.

@sindresorhus
Copy link
Owner

I think this is a bit soon. You need to first prove that you're a good maintainer for the list.

Also make sure the list passes the current guidelines and Awesome lint.

@dereuromark
Copy link
Author

dereuromark commented Nov 4, 2023

My track record of decades in open source should speak for itself :)
Also, as outlined, this should be a community thing moving forward, not a single bus factor Project.

Refs https://github.com/php-collective/awesome-php/issues/2

@dereuromark
Copy link
Author

dereuromark commented Nov 4, 2023

Fun fact:
I am the creator and primary maintainer of https://github.com/FriendsOfCake/awesome-cakephp already - as I am a core member of CakePHP framework for a very long time.

@dereuromark dereuromark changed the title Link to maintained successor Link to maintained successor for PHP Nov 5, 2023
@@ -274,7 +274,7 @@
- [OCaml](https://github.com/ocaml-community/awesome-ocaml#readme)
- [ColdFusion](https://github.com/seancoyne/awesome-coldfusion#readme)
- [Fortran](https://github.com/rabbiabram/awesome-fortran#readme)
- [PHP](https://github.com/ziadoz/awesome-php#readme) - Server-side scripting language.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ node --experimental-permission t.js
node:internal/modules/cjs/loader:162
const result = internalModuleStat(filename);
^

Error: Access to this API has been restricted
at stat (node:internal/modules/cjs/loader:162:18)
at Module._findPath (node:internal/modules/cjs/loader:640:16)
at resolveMainPath (node:internal/modules/run_main:15:25)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:53:24)
at node:internal/main/run_main_module:23:47 {
code: 'ERR_ACCESS_DENIED',
permission: 'FileSystemRead',
resource: '/Users/rafaelgss/repos/os/node/t.js'
}

@dereuromark
Copy link
Author

Also make sure the list passes the current guidelines and Awesome lint.

I would usually agree with you.
But switching to a maintained list on an existing item (basically a 1:1 replacement, quite literally) should have a different flow than adding a completely new list.
As such I would hope we can fast track this one

Any further needs to get the linting green will of course be taken as a group effort in the very near future.
But status quo on the old list is the same, so I dont see the need to have this as a hard requirement at the time being.

@alexkart
Copy link

Is there a final decision on how this should be handled?

@ziadoz
Copy link

ziadoz commented Dec 30, 2023

Hi. I'm the author of the original Awesome PHP list.

It seems like @dereuromark and @alexkart tried to reach out in an issue on my repo, but I only saw it today. Sorry about that. I've had a busy and stressful 2023.

I would prefer bringing on new collaborators to my list over a hard fork. Will discuss further on the issue. Thanks.

@dereuromark
Copy link
Author

Closing then for now since the original maintainer is back and we can collaborate.

@dereuromark dereuromark closed this Jan 4, 2024
@dereuromark dereuromark deleted the patch-1 branch January 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants