Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Adding hide/show button for canvas background color #121

Closed
AMISH-KHAN opened this issue May 14, 2024 · 13 comments
Closed

[FEAT] Adding hide/show button for canvas background color #121

AMISH-KHAN opened this issue May 14, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request gssoc level2

Comments

@AMISH-KHAN
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In the current UI there is a list of background color on left.
we can add the hide and show button Which will enhance the UI.

bgShow.mp4

Please assign this issue to me under GSSoC and add necessary labels

@AMISH-KHAN AMISH-KHAN added enhancement New feature or request up for grabs labels May 14, 2024
@singodiyashubham87
Copy link
Owner

@AMISH-KHAN This feature has already been implemented and there is an option to hide the tools and colors both.
Can you explain what uniqueness will this add to the application?

@AMISH-KHAN AMISH-KHAN changed the title [FEAT] Adding hide?show button for canvas background color [FEAT] Adding hide/show button for canvas background color May 14, 2024
@AMISH-KHAN
Copy link
Contributor Author

AMISH-KHAN commented May 14, 2024

@AMISH-KHAN This feature has already been implemented and there is an option to hide the tools and colors both. Can you explain what uniqueness will this add to the application?

The current UI has a feature to select any color from color picker but still it also has the list of other colors.

This causes the UI to overFlow from the screen.

reason.mp4

now Here we can either keep both color picker and other colors Tiles but then we need to implement my suggested feature to enhance UI and and get rid of unnecessary Scrolling.

bgShow.mp4

or we can keep only color picker and get rid of all other color tiles

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Fair enough, reduce the color palattes to 5-6 only, don't add a background color button & keep the 1st one which is color picker as it is so that user will have the option to choose any color of his/her choice.

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Assigned you the issue, Best of Luck!

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN I just saw that you are already assigned an issue, Once that issue is closed, I'll assign you this one.

@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 please assigned this issue to me as issue #97 is closed!

@ekramzafar
Copy link

@singodiyashubham87 can you assigned me

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Assigned you the issue, Best of luck :)

@singodiyashubham87
Copy link
Owner

@ekramzafar This issue is already assigned, Kindly explore other issues or create new ones.

@AMISH-KHAN
Copy link
Contributor Author

@AMISH-KHAN Assigned you the issue, Best of luck :)

Cool will start working on it soon

@AMISH-KHAN
Copy link
Contributor Author

AMISH-KHAN commented May 18, 2024

which one is better? @singodiyashubham87
1:

image

2:

image

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN 2nd one is much better, You can go with it.

AMISH-KHAN added a commit to AMISH-KHAN/Draw-it-out that referenced this issue May 19, 2024
@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 please review PR #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

No branches or pull requests

3 participants