Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes issue #97 #106

Merged
merged 7 commits into from
May 17, 2024
Merged

closes issue #97 #106

merged 7 commits into from
May 17, 2024

Conversation

AMISH-KHAN
Copy link
Contributor

Issue Title:

resolve issue: #97

Type of change ☑️

I have added labels and change the styling of icons so that it does not look bad

@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 9:24am
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 9:24am

@AMISH-KHAN AMISH-KHAN mentioned this pull request May 13, 2024
Closed
@AMISH-KHAN
Copy link
Contributor Author

hey @singodiyashubham87 I would like to work on some more complex issues which will help in understanding the project more.
Moreover, I would also like to hear your vision about this project.

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Kindly resolve the conflicts, So that your PR can be merged.

@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 please review it

singodiyashubham87
singodiyashubham87 requested changes May 15, 2024
View reviewed changes
Copy link
Owner

@singodiyashubham87 singodiyashubham87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMISH-KHAN Kindly change "color" to "Color" and align the tools vertically centered.

image

@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 I have made the requested changes Please review it.

Screenshot 2024-05-16 173315

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Kindly resolve the conflicts.

@AMISH-KHAN
Copy link
Contributor Author

Sure

@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 please review it

@singodiyashubham87 singodiyashubham87 merged commit b58894a into singodiyashubham87:main May 17, 2024
5 checks passed
@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Well Done, Keep Contributing :)

@AMISH-KHAN
Copy link
Contributor Author

@AMISH-KHAN Well Done, Keep Contributing :)

Thanks Please assign me this #121

@AMISH-KHAN AMISH-KHAN deleted the issue_#97 branch May 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singodiyashubham87 singodiyashubham87 singodiyashubham87 approved these changes

Assignees
No one assigned
Labels
gssoc level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMISH-KHAN @singodiyashubham87