Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : color picker doesn't working . #146

Merged

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

@Ayushmaanagarwal1211 Ayushmaanagarwal1211 commented May 17, 2024

Issue Title:

resolve issue: #144

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙️

Before :

bandicam.2024-05-17.14-13-29-606.mp4

After changes :

bandicam.2024-05-17.16-17-57-443.mp4

##Changes
I added color as well in the dependency array of useeffect hook where the canvas is updating only changing the thickness not it's been updating on changing the color as well .

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:50am
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:50am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Copy link
Collaborator

@soumya-maheshwari soumya-maheshwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Ready to be merged 🚀

@soumya-maheshwari soumya-maheshwari merged commit 8af7c72 into singodiyashubham87:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants