Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #137 : Resolving pen stroke feature #216

Closed
wants to merge 10 commits into from

Conversation

kumar1397
Copy link
Contributor

Issue Title:

resolve issue: #137

Type of change ☑️

What sort of change have you made:
I added some functions to ensure that on clicking of the pen button the thickness button can be turned on or off. And various types of pen styles can be selected by clicking on the arrow button.

Example how to mark a checkbox:-

  • My code follows the code style of this project.
    -->
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙️

I have checked the changes in my computer and it is working properly.
Screenshot 2024-05-27 200640
Screenshot 2024-05-27 200651
Screenshot 2024-05-27 200702

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 2:45pm
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 2:45pm

@singodiyashubham87
Copy link
Owner

@kumar1397 Your code is not synced with the latest changes, kindly resolve it.

Actual :

image

Yours:

image

I'll advice you to copy the changes you did to make your functionality work & re-clone the repo after syncing it & then make the changes then create a PR.

@singodiyashubham87 singodiyashubham87 added bug Something isn't working level2 labels May 29, 2024
@singodiyashubham87
Copy link
Owner

@kumar1397 Do update me or else I have to close the PR & unassign you the issue.

@singodiyashubham87
Copy link
Owner

closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants