Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title on hover #494

Closed
wants to merge 9 commits into from
Closed

Add title on hover #494

wants to merge 9 commits into from

Conversation

KomalSrivastava
Copy link

@KomalSrivastava KomalSrivastava commented Jul 26, 2024

Issue Title: Add hover effect and title

Fixes issue #477

Type of change ☑️

I have added hover in each and the title of the tool , when the user point curser to the icon then it show the effect and the title or you can say the topic.
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@singodiyashubham87 Review this and merge my issue.

How Has This Been Tested? ⚙️

Describe how have you verified the changes made.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ❌ Failed (Inspect) Aug 6, 2024 5:44am
draw-it-out-zbd1 ❌ Failed (Inspect) Aug 6, 2024 5:44am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Draw-it-out Outdated Show resolved Hide resolved
Copy link
Owner

@singodiyashubham87 singodiyashubham87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the changes.

@singodiyashubham87
Copy link
Owner

@KomalSrivastava You need to remove the submodules not add them.

@KomalSrivastava
Copy link
Author

@singodiyashubham87 removed.

@KomalSrivastava
Copy link
Author

@singodiyashubham87 Review and merge it please !!

@KomalSrivastava
Copy link
Author

@0xabdulkhalid @singodiyashubham87 ??

@singodiyashubham87
Copy link
Owner

@KomalSrivastava There is still a sub-module.
You should take care of all these things before creating a PR.
image

Please enter the commit message for your changes. Lines starting
@KomalSrivastava
Copy link
Author

@singodiyashubham87 I have removed .gitmodule may be haven't updated , my apology. now removed.

@KomalSrivastava KomalSrivastava closed this by deleting the head repository Aug 6, 2024
@KomalSrivastava
Copy link
Author

@singodiyashubham87 i will create new PR . here error is showing

@singodiyashubham87
Copy link
Owner

@KomalSrivastava Go Ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants