Added-title-name #512
Added-title-name #512
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| > | ||
| {darkMode ? ( | ||
| <FaSun className="text-black" /> | ||
| <FaSun className="text-black " title="LightMode" /> | ||
| ) : ( | ||
| <FaMoon className="text-white" /> | ||
| <FaMoon className="text-white" title="DarkMode"/> | ||
| )} |
There was a problem hiding this comment.
Hi there @kekubhai 👋🏻
The changes you made to improve accessibility is really impressive, but you still need to refactor this part a little bit. So that we can make truly accessible Theme Toggle.
You need to change the div into a button element, Then you need to add aria-label with "Theme Toggle - ${darkMode ? "Light" : "Dark"} Enabled". Now you can remove title from FontAwesome Icons, and add title="Theme Toggler" for the button element itself.
aria-label would help us in assisting accessibility devices, whereas title would provide a visual tooltip (only accessible for user who don't have visual problems).
Additionally, I've seen lot title attributes which are added to interactive elements. There's a thing you need to do, it's nothing much complicated. Just add aria-label attribute (for every elements where add you added title) copy the contents of title for aria-label so that we can assure users who have visual problems, they might rely on screen readers like accessibility devices.
|
thank you for your important insights.I know the error needs a proper
solution. I'll sure look into it and try to fix it as per your request
…On Sat, Aug 3, 2024 at 4:05 PM Abdul Khalid ***@***.***> wrote:
Assigned #512 <#512>
to @kekubhai <https://github.com/kekubhai>.
—
Reply to this email directly, view it on GitHub
<#512 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNZX2ZHGF7D3DRBRU5KBL3ZPSXADAVCNFSM6AAAAABL22GVNOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG42DSNJYG4YTONI>
.
You are receiving this because you were assigned.Message ID:
***@***.***
com>
|
|
sorry for the delay,I couln't get time time to perfrom the necessary changes. It would be better if you could assign any other contributer to work on the issue. |
|
@kekubhai, Are you sure? You have already done quite reasonable changes in this PR, for now you just need to refactor the changes you made. (You can refactor within 10 minutes, I already mentioned what needs be refactored). Decision is yours, If you still willing to not to work on this issue then let me know about it. So that i can close this PR and Assign any other willing person for contribution. |
|
Yes I'm completely okay with it. I have works which have tied me up. Deeply
regret my inability to work on it.
Please allow someone else to work on it
…On Tue, Aug 6, 2024, 6:57 AM Abdul Khalid ***@***.***> wrote:
@kekubhai <https://github.com/kekubhai>, Are you sure?
You have already done quite reasonable changes in this PR, for now you
just need to refactor the changes you made. (You can refactor within 10
minutes, I already mentioned what needs be refactored).
Decision is yours, And I'm waiting for your Confirmation
—
Reply to this email directly, view it on GitHub
<#512 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNZX25ONZANRV2KUJ5XZRTZQAQ7TAVCNFSM6AAAAABL22GVNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGE4TANRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
As you wish @kekubhai 🤝 |
Issue Title: Title Name not showing for icons
closes #508
Type of change ☑️
What sort of change have you made:
Checklist: ☑️
How Has This Been Tested? ⚙️
I have made my changes and tested by running on the localhost server. It is working fine and showing my done relevenat changes as per the given requirement.