Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for Issue#58 #94

Closed

Conversation

thatsyogeshjjr
Copy link
Contributor

@thatsyogeshjjr thatsyogeshjjr commented May 12, 2024

Issue Title:

resolve issue: #58

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

Changes made:

  • a popup for file save type (will save time in future file type additions as well)
  • Currently available export types: PNG, JPG
  • added a transparent background fill option

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ❌ Failed (Inspect) May 15, 2024 5:56pm
draw-it-out-zbd1 ❌ Failed (Inspect) May 15, 2024 5:56pm

@singodiyashubham87
Copy link
Owner

@thatsyogeshjjr Kindly add a working video of the changes that you made.

@thatsyogeshjjr
Copy link
Contributor Author

thatsyogeshjjr commented May 13, 2024

Issue.58.mp4

@singodiyashubham87 The first image saved is saved over a transparent background (w/o the smiley) displaying ability of the solution to save images as transparent png(s). The next two images are saved over a white background in jpg and png formats.

@singodiyashubham87
Copy link
Owner

@thatsyogeshjjr Kindly resolve the conflicts.

Copy link
Owner

@singodiyashubham87 singodiyashubham87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thatsyogeshjjr Use let instead of var and there is syntax error in your code you have misplace div instead of button, kindly fix that.

@thatsyogeshjjr
Copy link
Contributor Author

Wait,I have a better way to integrate it with the recent project changes, I'll be back with a new PR

@thatsyogeshjjr
Copy link
Contributor Author

@singodiyashubham87 I just made a new PR #139
The updates now integrate better with the newer UI

@thatsyogeshjjr thatsyogeshjjr deleted the Issue#58 branch May 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants