update rust reference code for bech32m #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add support for "bcrt" HRP
|
Hmm, is it desirable to restrict the code to bc/bcrt/tb? I don't think the other reference code does that. |
|
If not I'm happy to remove it. It seemed like an odd thing to do, but the existing Rust code did it. |
|
Yeah, I think I'd prefer removing that requirement. |
|
Removed. This did mean that we had to remove a couple test vectors (which are "invalid segwit addresses" according to BIP-173 and 350 but nonetheless valid bech32). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add support for "bcrt" HRP