Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause/resume waveOut option defaults to old behaviour #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

finebytes
Copy link

PauseAudio() and ResumeAudio() are only pausing _waveInEvent in WindowsAudioEndPoint but optionally _waveOutEvent needs to be paused as well. #10

@fred-peters
Copy link
Contributor

fred-peters commented Aug 9, 2023

Hi finebytes, according to my understanding of the project, PauseAudio and ResumeAudio are implmentation of the IAudioSource and not IAudioSink, that's why they should not deal with waveOutEvent., that's the purpose of the IAudioSink interface.
If you need a generic (in/out) PauseAudio, this should be implemented at the VoipMediaSession level.
This is unfortunate that the naming of the IAudioSource methods is generic (PauseAudio and ResumeAudio, it should be renamed to PauseAudioSource and ResumeAudioSource like it is correctly done of the IAudioSink interface which has PauseAudioSink and PauseAudioSource methods)

@sipsorcery
Copy link
Member

Is this still required after #12?

@fred-peters
Copy link
Contributor

I Suggest to rename the existing methods as described in my previous comment so it will be consistent with the other already existing PauseAudioSink and PauseAUdioSource, but not implement this change request which would create an asymetric behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants