Skip to content
This repository has been archived by the owner on Dec 27, 2024. It is now read-only.

fix: correctly integrate Sentry for Electron #282

Merged
merged 20 commits into from
Oct 17, 2024
Merged

Conversation

mtdvlpr
Copy link
Contributor

@mtdvlpr mtdvlpr commented Oct 15, 2024

I cleaned up the public folder, added the logo to home and added some emojis and custom containers.

You can find more VitePress Markdown features at: https://vitepress.dev/guide/markdown
The icons at home I got from: https://emojipedia.org/

I also fixed the Sentry integration for Electron by adding the Sentry/electron package and removing UI dependencies from the Electron process (Sentry/vue and quasar)

@sircharlo
Copy link
Owner

Very cool!
When I create a page in English, how do I go about adding that page in all the language folders? Manually?

@mtdvlpr
Copy link
Contributor Author

mtdvlpr commented Oct 15, 2024

Yeah, for now, it's manual labor. If you don't add them, they'll get a 404 error on that page. Once Crowdin is configured again, it will be automated.

@mtdvlpr
Copy link
Contributor Author

mtdvlpr commented Oct 15, 2024

You could, of course, add them already to mlthr meeting-media-manager repo like you do with the app strings.

@mtdvlpr mtdvlpr changed the title docs: prettify docs fix: correctly integrate Sentry for Electron Oct 17, 2024
@sircharlo
Copy link
Owner

You could, of course, add them already to mlthr meeting-media-manager repo like you do with the app strings.

Meh. We're close to publishing anyways. I think I'll wait for the refactor to be released before telling Crowdin what to look for.

@sircharlo
Copy link
Owner

Thanks for fixing the Sentry + Electron bug; makes perfect sense.

@sircharlo sircharlo merged commit afdfcd7 into sircharlo:main Oct 17, 2024
5 checks passed
@mtdvlpr
Copy link
Contributor Author

mtdvlpr commented Oct 17, 2024

You could, of course, add them already to mlthr meeting-media-manager repo like you do with the app strings.

Meh. We're close to publishing anyways. I think I'll wait for the refactor to be released before telling Crowdin what to look for.

Before activating Crowdin, I would suggest removing all the other locale pages so that Crowdin can correctly process them as untranslated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants