Skip to content

Commit

Permalink
try enable jpackage signing
Browse files Browse the repository at this point in the history
  • Loading branch information
mfleisch committed Aug 11, 2024
1 parent d45b87a commit 20f81c6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/distribute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
with:
gradle-version: 8.8
build-root-directory: sirius_dist/sirius_gui_dist
arguments: --stacktrace clean buildJpDists -P "build.sirius.native.openjfx.exclude=false" -P "build.sirius.starter.jdk.include=false" -P "de.unijena.bioinf.build.MACOS_APP_IDENTITY_ID=${{ secrets.MACOS_APP_IDENTITY_ID }}" -P "de.unijena.bioinf.build.MACOS_IDENTITY_ID=${{ secrets.MACOS_IDENTITY_ID }}" -P "de.unijena.bioinf.build.MACOS_APPLE_ID=${{ secrets.MACOS_APPLE_ID }}" -P "de.unijena.bioinf.build.MACOS_APPLE_ID_PW=${{ secrets.MACOS_APPLE_ID_PW }}" -P "de.unijena.bioinf.build.MACOS_TEAM_ID=${{ secrets.MACOS_TEAM_ID }}"
arguments: --stacktrace clean buildJpDists -P "build.sirius.native.openjfx.exclude=true" -P "build.sirius.starter.jdk.include=true" -P "de.unijena.bioinf.build.MACOS_APP_IDENTITY_ID=${{ secrets.MACOS_APP_IDENTITY_ID }}" -P "de.unijena.bioinf.build.MACOS_IDENTITY_ID=${{ secrets.MACOS_IDENTITY_ID }}" -P "de.unijena.bioinf.build.MACOS_APPLE_ID=${{ secrets.MACOS_APPLE_ID }}" -P "de.unijena.bioinf.build.MACOS_APPLE_ID_PW=${{ secrets.MACOS_APPLE_ID_PW }}" -P "de.unijena.bioinf.build.MACOS_TEAM_ID=${{ secrets.MACOS_TEAM_ID }}"

# - name: Sirius Run
# run: |
Expand Down
9 changes: 9 additions & 0 deletions sirius_dist/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,15 @@ abstract class AppImage extends DefaultTask {
paras += ["--icon", "${iconDir.resolve('sirius-icon.icns').toString()}"]
if (macPackageName != null && !macPackageName.isBlank())
paras += ['--mac-package-name', "\"$macPackageName\""]
def signID = project.findProperty("de.unijena.bioinf.build.MACOS_APP_IDENTITY_ID")
if (signID != null && !signID.isBlank()) {
paras += ['--mac-sign',
'--mac-package-signing-prefix', "com.brightgiant",
// '--mac-signing-keychain', "",
'--mac-signing-key-user-name', "$signID",
'--mac-entitlements', getRootProject().getProjectDir().toPath().resolve("dist").resolve("macos.entitlements").toFile().getAbsolutePath(),
]
}
} else if (project.siriusTargetPlatform.isLinux()) {
paras += ["--icon", "${iconDir.resolve('sirius-icon.png').toString()}"]
} else {
Expand Down

0 comments on commit 20f81c6

Please sign in to comment.