Merge pull request #97 from sitegeist/task/96/preventHugeInlinePlaceh…

…older [TASK] Check processed placeholder to prevent large inline images
sitegeist · Feb 21, 2022 · c5358ef · c5358ef
2 parents 2eb82c8 + 3e7ff5e
commit c5358ef
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/Classes/Utility/ResponsiveImagesUtility.php b/Classes/Utility/ResponsiveImagesUtility.php
@@ -532,6 +532,11 @@ public function generatePlaceholderImage(
  }
  $processedImage = $this->imageService->applyProcessingInstructions($image, $processingInstructions);
 
+ // Disable inline placeholder if the image is not processed at all
+ if ($processedImage->usesOriginalFile()) {
+ $inline = false;
+ }
+
  if ($inline) {
  return $this->generateDataUri($processedImage);
  } else {

diff --git a/Tests/Unit/Utility/ResponsiveImagesUtility/AbstractResponsiveImagesUtilityTest.php b/Tests/Unit/Utility/ResponsiveImagesUtility/AbstractResponsiveImagesUtilityTest.php
@@ -72,7 +72,7 @@ protected function mockFileObject($properties, $processed = false)
 
  $fileMock = $this->getMockBuilder($processed ? ProcessedFile::class : FileReference::class)
  ->disableOriginalConstructor()
- ->setMethods(['getProperty', 'getMimeType', 'getContents'])
+ ->setMethods(['getProperty', 'getMimeType', 'getContents', 'usesOriginalFile'])
  ->getMock();
 
  $fileMock
@@ -90,6 +90,11 @@ protected function mockFileObject($properties, $processed = false)
  ->will($this->returnCallback(function () use ($properties) {
  return 'das-ist-der-dateiinhalt';
  }));
+ $fileMock
+ ->method('usesOriginalFile')
+ ->will($this->returnCallback(function () use ($properties) {
+ return false;
+ }));
 
  return $fileMock;
  }

diff --git a/ext_emconf.php b/ext_emconf.php
@@ -9,7 +9,7 @@
  'state' => 'stable',
  'uploadfolder' => false,
  'clearCacheOnLoad' => false,
- 'version' => '2.1.2',
+ 'version' => '2.1.3',
  'constraints' => [
  'depends' => [
  'typo3' => '9.5.0-11.9.99',