Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masked input #280

Closed
wants to merge 2 commits into from
Closed

Masked input #280

wants to merge 2 commits into from

Conversation

Nymoth
Copy link

@Nymoth Nymoth commented Aug 5, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • [X ] ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Nymoth Nymoth changed the title Masked input draft Masked input Aug 5, 2024
@colinscz
Copy link
Collaborator

colinscz commented Aug 8, 2024

Hi @Nymoth
thanks for the contribution, please reach out in the teams webcomponents channel in case you have any questions or approach somebody of the core team.

@pennal
Copy link
Collaborator

pennal commented Aug 15, 2024

Hi @Nymoth,

first of all, thank you for your contribution!

We have discussed this PR internally and have decided not to merge it. The reason is that we believe this functionality is better done at the framework level, instead of the webcomponents level. This way the users can decide the library that fits their use case best, depending on the frontend framework (or lack thereof) being used

@pennal pennal closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants