test: add more test case

siyul-park · Oct 9, 2024 · 3eba618 · 3eba618
1 parent e66b1e5
commit 3eba618
Show file tree

Hide file tree

Showing 6 changed files with 64 additions and 41 deletions.
diff --git a/cmd/pkg/cli/apply_test.go b/cmd/pkg/cli/apply_test.go
@@ -10,7 +10,6 @@ import (
 	"github.com/go-faker/faker/v4"
 	"github.com/gofrs/uuid"
 	"github.com/siyul-park/uniflow/pkg/chart"
-	"github.com/siyul-park/uniflow/pkg/resource"
 	"github.com/siyul-park/uniflow/pkg/secret"
 	"github.com/siyul-park/uniflow/pkg/spec"
 	"github.com/spf13/afero"
@@ -31,9 +30,8 @@ func TestApplyCommand_Execute(t *testing.T) {
 		filename := "chart.json"
 
 		chrt := &chart.Chart{
-			ID:        uuid.Must(uuid.NewV7()),
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.Word(),
+			ID:   uuid.Must(uuid.NewV7()),
+			Name: faker.Word(),
 		}
 
 		data, err := json.Marshal(chrt)
@@ -75,9 +73,8 @@ func TestApplyCommand_Execute(t *testing.T) {
 		filename := "chart.json"
 
 		chrt := &chart.Chart{
-			ID:        uuid.Must(uuid.NewV7()),
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.Word(),
+			ID:   uuid.Must(uuid.NewV7()),
+			Name: faker.Word(),
 		}
 
 		_, err := chartStore.Store(ctx, chrt)
@@ -124,9 +121,8 @@ func TestApplyCommand_Execute(t *testing.T) {
 		kind := faker.UUIDHyphenated()
 
 		meta := &spec.Meta{
-			Kind:      kind,
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
+			Kind: kind,
+			Name: faker.UUIDHyphenated(),
 		}
 
 		data, err := json.Marshal(meta)
@@ -170,9 +166,8 @@ func TestApplyCommand_Execute(t *testing.T) {
 		kind := faker.UUIDHyphenated()
 
 		meta := &spec.Meta{
-			Kind:      kind,
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
+			Kind: kind,
+			Name: faker.UUIDHyphenated(),
 		}
 
 		_, err := specStore.Store(ctx, meta)
@@ -217,9 +212,8 @@ func TestApplyCommand_Execute(t *testing.T) {
 		filename := "secrets.json"
 
 		scrt := &secret.Secret{
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
-			Data:      faker.Word(),
+			Name: faker.UUIDHyphenated(),
+			Data: faker.Word(),
 		}
 
 		data, err := json.Marshal(scrt)
@@ -261,9 +255,8 @@ func TestApplyCommand_Execute(t *testing.T) {
 		filename := "secrets.json"
 
 		scrt := &secret.Secret{
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
-			Data:      faker.Word(),
+			Name: faker.UUIDHyphenated(),
+			Data: faker.Word(),
 		}
 
 		_, err := secretStore.Store(ctx, scrt)

diff --git a/cmd/pkg/cli/delete_test.go b/cmd/pkg/cli/delete_test.go
@@ -9,7 +9,6 @@ import (
 	"github.com/go-faker/faker/v4"
 	"github.com/gofrs/uuid"
 	"github.com/siyul-park/uniflow/pkg/chart"
-	"github.com/siyul-park/uniflow/pkg/resource"
 	"github.com/siyul-park/uniflow/pkg/secret"
 	"github.com/siyul-park/uniflow/pkg/spec"
 	"github.com/spf13/afero"
@@ -30,9 +29,8 @@ func TestDeleteCommand_Execute(t *testing.T) {
 		filename := "chart.json"
 
 		chrt := &chart.Chart{
-			ID:        uuid.Must(uuid.NewV7()),
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.Word(),
+			ID:   uuid.Must(uuid.NewV7()),
+			Name: faker.Word(),
 		}
 
 		data, err := json.Marshal(chrt)
@@ -74,9 +72,8 @@ func TestDeleteCommand_Execute(t *testing.T) {
 		kind := faker.UUIDHyphenated()
 
 		meta := &spec.Meta{
-			Kind:      kind,
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
+			Kind: kind,
+			Name: faker.UUIDHyphenated(),
 		}
 
 		data, err := json.Marshal(meta)
@@ -116,9 +113,8 @@ func TestDeleteCommand_Execute(t *testing.T) {
 		filename := "secrets.json"
 
 		scrt := &secret.Secret{
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
-			Data:      faker.Word(),
+			Name: faker.UUIDHyphenated(),
+			Data: faker.Word(),
 		}
 
 		data, err := json.Marshal(scrt)

diff --git a/cmd/pkg/cli/get_test.go b/cmd/pkg/cli/get_test.go
@@ -8,7 +8,6 @@ import (
 	"github.com/go-faker/faker/v4"
 	"github.com/gofrs/uuid"
 	"github.com/siyul-park/uniflow/pkg/chart"
-	"github.com/siyul-park/uniflow/pkg/resource"
 	"github.com/siyul-park/uniflow/pkg/secret"
 	"github.com/siyul-park/uniflow/pkg/spec"
 	"github.com/stretchr/testify/assert"
@@ -24,9 +23,8 @@ func TestGetCommand_Execute(t *testing.T) {
 		defer cancel()
 
 		chrt := &chart.Chart{
-			ID:        uuid.Must(uuid.NewV7()),
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.Word(),
+			ID:   uuid.Must(uuid.NewV7()),
+			Name: faker.Word(),
 		}
 
 		_, err := chartStore.Store(ctx, chrt)
@@ -56,9 +54,8 @@ func TestGetCommand_Execute(t *testing.T) {
 		kind := faker.UUIDHyphenated()
 
 		meta := &spec.Meta{
-			Kind:      kind,
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
+			Kind: kind,
+			Name: faker.UUIDHyphenated(),
 		}
 
 		_, err := specStore.Store(ctx, meta)
@@ -86,9 +83,8 @@ func TestGetCommand_Execute(t *testing.T) {
 		defer cancel()
 
 		scrt := &secret.Secret{
-			Namespace: resource.DefaultNamespace,
-			Name:      faker.UUIDHyphenated(),
-			Data:      faker.Word(),
+			Name: faker.UUIDHyphenated(),
+			Data: faker.Word(),
 		}
 
 		_, err := secretStore.Store(ctx, scrt)

diff --git a/cmd/pkg/cli/start_test.go b/cmd/pkg/cli/start_test.go
@@ -5,6 +5,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"strings"
 	"testing"
 	"time"
 
@@ -40,6 +41,43 @@ func TestStartCommand_Execute(t *testing.T) {
 	s.AddKnownType(kind, &spec.Meta{})
 	s.AddCodec(kind, codec)
 
+	t.Run(flagDebug, func(t *testing.T) {
+		ctx, cancel := context.WithTimeout(context.Background(), time.Second)
+		defer cancel()
+
+		output := new(bytes.Buffer)
+
+		cmd := NewStartCommand(StartConfig{
+			Scheme:      s,
+			Hook:        h,
+			FS:          fs,
+			ChartStore:  chartStore,
+			SpecStore:   specStore,
+			SecretStore: secretStore,
+		})
+		cmd.SetOut(output)
+		cmd.SetErr(output)
+		cmd.SetContext(ctx)
+
+		cmd.SetArgs([]string{fmt.Sprintf("--%s", flagDebug)})
+
+		go func() {
+			_ = cmd.Execute()
+		}()
+
+		for {
+			select {
+			case <-ctx.Done():
+				assert.Fail(t, ctx.Err().Error())
+				return
+			default:
+				if strings.Contains(output.String(), "debug") {
+					return
+				}
+			}
+		}
+	})
+
 	t.Run(flagFromCharts, func(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), time.Second)
 		defer cancel()

diff --git a/pkg/chart/loader.go b/pkg/chart/loader.go
@@ -87,7 +87,7 @@ func (l *Loader) Load(ctx context.Context, charts ...*Chart) error {
 			}
 			if !ok {
 				if _, err := l.table.Free(id); err != nil {
-					return err
+					errs = append(errs, err)
 				}
 			}
 		}

diff --git a/pkg/symbol/loader.go b/pkg/symbol/loader.go
@@ -122,7 +122,7 @@ func (l *Loader) Load(ctx context.Context, specs ...spec.Spec) error {
 			}
 			if !ok {
 				if _, err := l.table.Free(id); err != nil {
-					return err
+					errs = append(errs, err)
 				}
 			}
 		}