Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: be simple primitive #24

Merged
merged 10 commits into from
Nov 29, 2023
Merged

refactor: be simple primitive #24

merged 10 commits into from
Nov 29, 2023

Conversation

siyul-park
Copy link
Owner

Changes Made

This pull request includes various improvements and additions to the existing codebase. The major changes made are:

  • Refactored the implementation of String, Map, Slice, and more types.
  • Added missing test cases for the refactored code.
  • Introduced benchmark tests for performance evaluation of key methods.

Additional Information

  • The refactored code enhances the readability and maintainability of the types.
  • All test cases have been reviewed and updated to ensure comprehensive coverage.
  • New benchmark tests provide insights into the performance of key methods.

@siyul-park siyul-park self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 237 lines in your changes are missing coverage. Please review.

Comparison is base (4f8738a) 63.68% compared to head (ff3b3da) 63.65%.

Files Patch % Lines
pkg/primitive/int.go 58.01% 50 Missing and 5 partials ⚠️
pkg/primitive/uint.go 57.69% 50 Missing and 5 partials ⚠️
pkg/primitive/float.go 42.46% 42 Missing ⚠️
pkg/primitive/map.go 66.12% 19 Missing and 2 partials ⚠️
pkg/primitive/slice.go 68.42% 14 Missing and 4 partials ⚠️
pkg/primitive/value.go 18.75% 9 Missing and 4 partials ⚠️
pkg/database/memdb/filter.go 23.07% 0 Missing and 10 partials ⚠️
pkg/primitive/iterator.go 45.45% 4 Missing and 2 partials ⚠️
pkg/database/mongodb/encoding.go 73.33% 4 Missing ⚠️
pkg/primitive/binary.go 80.95% 3 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   63.68%   63.65%   -0.03%     
==========================================
  Files          75       76       +1     
  Lines        6532     6535       +3     
==========================================
  Hits         4160     4160              
- Misses       1798     1835      +37     
+ Partials      574      540      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siyul-park siyul-park merged commit c287b32 into main Nov 29, 2023
5 of 6 checks passed
@siyul-park siyul-park deleted the feature/refactor_primitive branch November 29, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant