-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove util package #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to streamline the codebase by eliminating the
util
package and enhancing the data handling capabilities in theprimitive
package.Changes Made
Removal of
util
Package:util
package has been entirely removed from the project as its functionalities are now covered by the more versatile and widely-used https://github.com/samber/lo package.Improved Comparison in
primitive
:primitive
package now supports native comparison in place of the previous implementation. This not only enhances efficiency but also simplifies the codebase.Transition to Ordered Map:
primitive
package has been replaced with an ordered map, contributing to more predictable iteration and ordering of elements.Elimination of Unnecessary Hash Support in
primitive
:primitive
package has been removed, eliminating unnecessary redundancy.These changes collectively aim to improve code maintainability, reduce redundancy, and leverage widely accepted practices in the Go ecosystem. Please review the modifications and provide your feedback.