Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove util package #9

Merged
merged 18 commits into from
Nov 24, 2023
Merged

refactor: remove util package #9

merged 18 commits into from
Nov 24, 2023

Conversation

siyul-park
Copy link
Owner

@siyul-park siyul-park commented Nov 24, 2023

This pull request aims to streamline the codebase by eliminating the util package and enhancing the data handling capabilities in the primitive package.

Changes Made

  1. Removal of util Package:

    • The util package has been entirely removed from the project as its functionalities are now covered by the more versatile and widely-used https://github.com/samber/lo package.
  2. Improved Comparison in primitive:

    • The primitive package now supports native comparison in place of the previous implementation. This not only enhances efficiency but also simplifies the codebase.
  3. Transition to Ordered Map:

    • The hash map in the primitive package has been replaced with an ordered map, contributing to more predictable iteration and ordering of elements.
  4. Elimination of Unnecessary Hash Support in primitive:

    • Given the enhancements in native comparison, the support for hash in the primitive package has been removed, eliminating unnecessary redundancy.

These changes collectively aim to improve code maintainability, reduce redundancy, and leverage widely accepted practices in the Go ecosystem. Please review the modifications and provide your feedback.

@siyul-park siyul-park self-assigned this Nov 24, 2023
@siyul-park siyul-park added the enhancement New feature or request label Nov 24, 2023
@siyul-park siyul-park merged commit 538e05b into main Nov 24, 2023
6 checks passed
@siyul-park siyul-park deleted the feature/simplify_util branch November 24, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant