Skip to content

Commit

Permalink
[Upbit] Add net_type parameter of main network for deposit information
Browse files Browse the repository at this point in the history
  • Loading branch information
sjanel committed Nov 3, 2023
1 parent 5ad7c0e commit 0b319c0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ Main features:
- [Dust sweeper](#dust-sweeper)
- [Monitoring options](#monitoring-options)
- [Repeat](#repeat)
- [Limitations](#limitations)
- [Examples of use cases](#examples-of-use-cases)
- [Get an overview of your portfolio in Korean Won](#get-an-overview-of-your-portfolio-in-korean-won)
- [Trade 1000 euros to XRP on kraken with a maker strategy](#trade-1000-euros-to-xrp-on-kraken-with-a-maker-strategy)
Expand Down Expand Up @@ -766,6 +767,19 @@ Without a following numeric value, the command will repeat endlessly. You can fi

Between each repeat you can set a waiting time with `--repeat-time` option which expects a time duration.

## Limitations

Be aware of the following limitations of `coincenter`:

- When several networks exist for a given currency, only the **main one** is considered.
This is to ensure safety between withdrawals performed between exchanges.
- Only absolute withdraw fees are currently supported.
In some cases (seen in Huobi), withdraw fee can be a percentage. They will be considered as 0.
- Not really a limitation, but some **sensitive actions are not possible** by the exchanges API.
For instance, withdrawal for Kraken is only possible for a stored destination made from the website first.

And probably more that I did not thought of, or never encountered. Feel free to open an issue and I will check it out if it's feasible!

## Examples of use cases

### Get an overview of your portfolio in Korean Won
Expand Down
2 changes: 1 addition & 1 deletion src/api/exchanges/src/upbitprivateapi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ BalancePortfolio UpbitPrivate::queryAccountBalance(const BalanceOptions& balance
}

Wallet UpbitPrivate::DepositWalletFunc::operator()(CurrencyCode currencyCode) {
CurlPostData postData{{"currency", currencyCode.str()}};
CurlPostData postData{{"currency", currencyCode.str()}, {"net_type", currencyCode.str()}};
json result = PrivateQuery(_curlHandle, _apiKey, HttpRequestType::kGet, "/v1/deposits/coin_address", postData,
IfError::kNoThrow);
bool generateDepositAddressNeeded = false;
Expand Down

0 comments on commit 0b319c0

Please sign in to comment.