Force gzip/deflate compression binance common api as the result is co…

…mpressed
sjanel · Nov 19, 2024 · 25b82a7 · 25b82a7
1 parent f45b0f1
commit 25b82a7
Show file tree

Hide file tree

Showing 7 changed files with 43 additions and 44 deletions.
diff --git a/CONFIG.md b/CONFIG.md
diff --git a/src/api/common/include/exchange-permanent-curl-options.hpp b/src/api/common/include/exchange-permanent-curl-options.hpp
@@ -5,9 +5,7 @@
 #include "exchange-query-config.hpp"
 #include "permanentcurloptions.hpp"
 
-namespace cct {
-
-namespace api {
+namespace cct::api {
 
 class ExchangePermanentCurlOptions {
  public:
@@ -21,6 +19,4 @@ class ExchangePermanentCurlOptions {
   const schema::ExchangeQueryConfig &_queryConfig;
 };
 
-}  // namespace api
-
-}  // namespace cct
+}  // namespace cct::api
diff --git a/src/api/common/src/commonapi.cpp b/src/api/common/src/commonapi.cpp
@@ -7,6 +7,7 @@
 #include <utility>
 
 #include "cachedresult.hpp"
+#include "cct_const.hpp"
 #include "cct_json-container.hpp"
 #include "cct_log.hpp"
 #include "cct_string.hpp"
@@ -39,6 +40,7 @@ CommonAPI::CommonAPI(const CoincenterInfo& coincenterInfo, Duration fiatsUpdateF
                           coincenterInfo.metricGatewayPtr(),
                           PermanentCurlOptions::Builder()
                               .setFollowLocation()
+                              .setAcceptedEncoding(kDefaultAcceptEncoding)
                               .setTooManyErrorsPolicy(PermanentCurlOptions::TooManyErrorsPolicy::kReturnEmptyResponse)
                               .build(),
                           coincenterInfo.getRunMode()),

diff --git a/src/basic-objects/include/cct_const.hpp b/src/basic-objects/include/cct_const.hpp
@@ -53,4 +53,6 @@ static constexpr int kNbSupportedExchanges = static_cast<int>(std::size(kSupport
 
 static constexpr int kTypicalNbPrivateAccounts = kNbSupportedExchanges;
 
+static constexpr std::string_view kDefaultAcceptEncoding = "gzip,deflate";
+
 }  // namespace cct
diff --git a/src/schema/include/write-json.hpp b/src/schema/include/write-json.hpp
@@ -3,7 +3,6 @@
 #include "cct_exception.hpp"
 #include "cct_json-serialization.hpp"
 #include "cct_string.hpp"
-#include "writer.hpp"
 
 namespace cct {
 

diff --git a/src/schema/src/exchange-config-default.hpp b/src/schema/src/exchange-config-default.hpp
@@ -80,7 +80,7 @@ struct ExchangeConfigDefault {
     },
     "exchange": {
       "binance": {
-        "acceptEncoding": "gzip",
+        "acceptEncoding": "gzip,deflate",
         "privateAPIRate": "150ms",
         "publicAPIRate": "55ms"
       },

diff --git a/src/schema/test/exchange-config_test.cpp b/src/schema/test/exchange-config_test.cpp
@@ -87,7 +87,7 @@ class ExchangeConfigTest : public ::testing::Test {
     },
     "exchange": {
       "binance": {
-        "acceptEncoding": "gzip",
+        "acceptEncoding": "gzip,deflate",
         "privateAPIRate": "150ms",
         "publicAPIRate": "55ms"
       },
@@ -177,7 +177,7 @@ TEST_F(ExchangeConfigTest, DirectRead) {
   EXPECT_EQ(exchangeConfigOptional.query.def.updateFrequency->size(), 9);
   EXPECT_EQ(exchangeConfigOptional.query.def.validateApiKey, false);
   EXPECT_EQ(exchangeConfigOptional.query.exchange.size(), 6);
-  EXPECT_EQ(exchangeConfigOptional.query.exchange.at(ExchangeNameEnum::binance).acceptEncoding, "gzip");
+  EXPECT_EQ(exchangeConfigOptional.query.exchange.at(ExchangeNameEnum::binance).acceptEncoding, "gzip,deflate");
 }
 
 TEST_F(ExchangeConfigTest, ExchangeValuesShouldOverrideDefault) {
@@ -190,7 +190,7 @@ TEST_F(ExchangeConfigTest, ExchangeValuesShouldOverrideDefault) {
   EXPECT_EQ(allExchangeConfigs[ExchangeNameEnum::binance].asset.allExclude, CurrencyCodeSet{"BQX"});
   EXPECT_EQ(allExchangeConfigs[ExchangeNameEnum::kraken].asset.withdrawExclude,
             CurrencyCodeSet({"AUD", "CAD", "CHF", "EUR", "GBP", "JPY", "KRW", "USD", "KFEE"}));
-  EXPECT_EQ(allExchangeConfigs[ExchangeNameEnum::binance].query.acceptEncoding, "gzip");
+  EXPECT_EQ(allExchangeConfigs[ExchangeNameEnum::binance].query.acceptEncoding, "gzip,deflate");
   EXPECT_EQ(allExchangeConfigs[ExchangeNameEnum::binance].query.privateAPIRate.duration,
             std::chrono::milliseconds(150));
   EXPECT_EQ(allExchangeConfigs[ExchangeNameEnum::binance].query.publicAPIRate.duration, std::chrono::milliseconds(55));
Original file line number	Diff line number	Diff line change
Expand Up		@@ -53,4 +53,6 @@ static constexpr int kNbSupportedExchanges = static_cast<int>(std::size(kSupport

		static constexpr int kTypicalNbPrivateAccounts = kNbSupportedExchanges;

		static constexpr std::string_view kDefaultAcceptEncoding = "gzip,deflate";

		} // namespace cct