Return market data instead of void

src/engine/include/coincenter.hpp

@@ -53,9 +53,9 @@ class Coincenter {
                                                      CurrencyCode equiCurrencyCode,
                                                      std::optional<int> depth = std::nullopt);
 
-  /// Query market data without returning it.
+  /// Query market data (order books and last trades).
   /// This method is especially useful for serialization and metric exports.
-  void queryMarketDataPerExchange(std::span<const Market> marketPerPublicExchange);
+  MarketDataPerExchange queryMarketDataPerExchange(std::span<const Market> marketPerPublicExchangePos);
 
   /// Retrieve the last 24h traded volume for exchanges supporting given market.
   MonetaryAmountPerExchange getLast24hTradedVolumePerExchange(Market mk, ExchangeNameSpan exchangeNames);

src/engine/src/coincenter.cpp

@@ -72,19 +72,19 @@ MarketOrderBookConversionRates Coincenter::getMarketOrderBooks(Market mk, Exchan
   return ret;
 }
 
-void Coincenter::queryMarketDataPerExchange(std::span<const Market> marketPerPublicExchange) {
+MarketDataPerExchange Coincenter::queryMarketDataPerExchange(std::span<const Market> marketPerPublicExchangePos) {
   ExchangeNames exchangeNames;
 
   int exchangePos{};
-  for (Market market : marketPerPublicExchange) {
+  for (Market market : marketPerPublicExchangePos) {
     if (market.isDefined()) {
       exchangeNames.emplace_back(kSupportedExchanges[exchangePos]);
     }
     ++exchangePos;
   }
 
   const auto marketDataPerExchange =
-      _exchangesOrchestrator.getMarketDataPerExchange(marketPerPublicExchange, exchangeNames);
+      _exchangesOrchestrator.getMarketDataPerExchange(marketPerPublicExchangePos, exchangeNames);
 
   // Transform data structures to export metrics input format
   MarketOrderBookConversionRates marketOrderBookConversionRates(marketDataPerExchange.size());
@@ -104,6 +104,8 @@ void Coincenter::queryMarketDataPerExchange(std::span<const Market> marketPerPub
 
   _metricsExporter.exportOrderbookMetrics(marketOrderBookConversionRates);
   _metricsExporter.exportLastTradesMetrics(lastTradesPerExchange);
+
+  return marketDataPerExchange;
 }
 
 BalancePerExchange Coincenter::getBalance(std::span<const ExchangeName> privateExchangeNames,

src/engine/src/exchangesorchestrator.cpp

@@ -968,9 +968,6 @@ MarketDataPerExchange ExchangesOrchestrator::getMarketDataPerExchange(std::span<
 
   MarketDataPerExchange ret(selectedExchanges.size());
   _threadPool.parallelTransform(selectedExchanges, ret.begin(), [&marketPerPublicExchange](Exchange *exchange) {
-    if (!exchange->exchangeConfig().withMarketDataSerialization()) {
-      log::warn("Calling market-data on {} with data serialization disabled", exchange->name());
-    }
     // Call order book and last trades sequentially for this exchange
     Market market = marketPerPublicExchange[exchange->publicExchangePos()];
 
@@ -1071,4 +1068,4 @@ MarketTradingGlobalResultPerExchange ExchangesOrchestrator::getMarketTraderResul
   return marketTradingGlobalResultPerExchange;
 }
 
-}  // namespace cct
+}  // namespace cct

src/engine/test/coincenteroptions_test.cpp

@@ -49,8 +49,9 @@ TEST_F(CoincenterCmdLineOptionsTest, DefaultConstructorShouldValueInitializeAll)
 
   EXPECT_EQ(opts, *pRhs);
 
-  static_assert(std::is_trivially_destructible_v<CoincenterCmdLineOptions>,
-                "then destructor should be called (but ideally this type should stay trivially destructible)");
+  if constexpr (!std::is_trivially_destructible_v<CoincenterCmdLineOptions>) {
+    std::destroy_at(pRhs);
+  }
 }
 
 TEST_F(CoincenterCmdLineOptionsTest, MergeGlobal) {

src/objects/include/file.hpp

@@ -15,6 +15,11 @@ class File : public Reader, public Writer {
   enum class Type : int8_t { kCache, kSecret, kStatic, kLog };
   enum class IfError : int8_t { kThrow, kNoThrow };
 
+  /// Creates a File directly from a file path.
+  File(std::string_view filePath, IfError ifError);
+
+  /// Creates a File from the coincenter data directory, with the type of the file and its name in the main data
+  /// directory.
   File(std::string_view dataDir, Type type, std::string_view name, IfError ifError);
 
   [[nodiscard]] string readAll() const override;

src/objects/src/file.cpp

@@ -37,6 +37,8 @@ string FullFileName(std::string_view dataDir, std::string_view fileName, File::T
 }
 }  // namespace
 
+File::File(std::string_view filePath, IfError ifError) : _filePath(filePath), _ifError(ifError) {}
+
 File::File(std::string_view dataDir, Type type, std::string_view name, IfError ifError)
     : _filePath(FullFileName(dataDir, name, type)), _ifError(ifError) {}
 
@@ -49,7 +51,7 @@ string File::readAll() const {
       throw exception("Unable to open {} for reading", _filePath);
     }
     try {
-      data = string((std::istreambuf_iterator<char>(file)), std::istreambuf_iterator<char>());
+      data = string(std::istreambuf_iterator<char>(file), std::istreambuf_iterator<char>());
     } catch (const std::exception& e) {
       if (_ifError == IfError::kThrow) {
         throw e;

src/tech/include/cct_const.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <algorithm>
 #include <iterator>
 #include <string_view>
 
@@ -18,6 +19,8 @@ static constexpr std::string_view kDepositAddressesFileName = "depositaddresses.
 
 static constexpr std::string_view kSupportedExchanges[] = {"binance", "bithumb", "huobi", "kraken", "kucoin", "upbit"};
 
+static_assert(std::ranges::is_sorted(kSupportedExchanges));
+
 static constexpr int kNbSupportedExchanges = static_cast<int>(std::size(kSupportedExchanges));
 
 static constexpr int kTypicalNbPrivateAccounts = kNbSupportedExchanges;