Add retry mechanism to requests #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanel
added
enhancement
sjanel
force-pushed
the
feature/factorize-request-retries-public-requests-exchanges
branch
from
919636a to
292c2e9
Compare
sjanel
deleted the
feature/factorize-request-retries-public-requests-exchanges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorize retry mechanism code into a class that is used by public API exchanges. Also add internal curl request retries.
Also, instead of throwing an exception after too many failed queries, we return an empty json instead and the code can deal with it without crashing. This makes
coincentermore robust for long-term running in case of connection disruptions.