Skip to content

Commit

Permalink
Remove explicit versions from requirements.txt
Browse files Browse the repository at this point in the history
  • Loading branch information
sk-zk committed May 24, 2024
1 parent 88526e9 commit 2835b86
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
24 changes: 12 additions & 12 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
numpy~=1.24.2
Pillow~=9.2.0
pyproj~=3.5.0
requests~=2.28.1
pytest~=7.2.1
pytest-asyncio~=0.21.1
numpy
Pillow
pyproj
requests
pytest
pytest-asyncio
protobuf~=4.21.9
pyfrpc~=0.2.7
scipy~=1.9.1
aiohttp~=3.8.3
pycryptodome~=3.15.0
pyequilib~=0.5.7
cython~=3.0.10
pyfrpc
scipy
aiohttp
pycryptodome
pyequilib
cython

1 comment on commit 2835b86

@sk-zk
Copy link
Owner Author

@sk-zk sk-zk commented on 2835b86 May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyfrpc finally added 3.12 support, so this library can officially support 3.12 now as well. Explicit version numbers in requirements.txt don't really work when targeting both 3.8 and 3.12 though, so they're gone. The exception to this is protobuf, which absolutely cannot be version 3 or lower, but many other libraries still require it, so it needs to be explicitly stated that we need version 4 here.

Please sign in to comment.