Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update vite-plugin-tailwind-purgecss and PurgeCSS docs #2604

Merged
merged 12 commits into from
Apr 12, 2024

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Apr 9, 2024

Description

vite-plugin-tailwind-purgecss purging strategy has been overhauled and released as of version 0.3.0: AdrianGonz97/vite-plugin-tailwind-purgecss#27 (also includes a migration guide)

This PR updates the vite plugin to its latest version and it also updates the installation instructions for the purgecss docs page.


CSA also needs to be updated to remove this section as it's no longer needed:

if (opts.codeblocks) {
contents += `{
safelist: {
// any selectors that begin with "hljs-" will not be purged
greedy: [/^hljs-/],
},
}),
],
});`;
} else {
contents += `)]
});`;

However, I noticed that the versions (0.0.53) in the package.json is out-of-sync with the published version on npm (0.0.54): https://www.npmjs.com/package/create-skeleton-app, so I've left that out of this PR. Any guidance on how to go about this @niktek?

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-next ❌ Failed (Inspect) Apr 12, 2024 6:20pm
skeleton-themes ❌ Failed (Inspect) Apr 12, 2024 6:20pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 6:20pm

Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 359cff5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-skeleton-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endigo9740
Copy link
Contributor

endigo9740 commented Apr 9, 2024

@niktek FYI this will come with a CSA change. Let me know if you would like me to create a ticket for this.

@endigo9740
Copy link
Contributor

@niktek Adrian was able to pull in the most recent changes to the CSA, so we're going to go ahead and merge and release to production. If you could please review the changes when you get a moment (no rush) and verify that all is well. Feel free to follow up if we need to modify anything else. Adrian and I are happy to help where we can!

@endigo9740 endigo9740 merged commit d2c429a into dev Apr 12, 2024
5 of 7 checks passed
@endigo9740 endigo9740 deleted the chore/update-purge-plugin branch April 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants