Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a syntax warning in the Step 2 workflow #58

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix a syntax warning in the Step 2 workflow #58

merged 1 commit into from
Sep 12, 2023

Conversation

sinsukehlab
Copy link
Contributor

@sinsukehlab sinsukehlab commented Sep 12, 2023 •
edited
Loading

Restore the commit_id output

Summary

Currently, the workflow doesn't properly check if the comment body contains the commit ID.

Changes

Edit 2-find-commit-in-history.yml
Add the get_commit_id step to the get_current_step job
Use the commid_id output from the get_commit_id step

Closes: #52

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@sinsukehlab
Fix a syntax warning in the Step 2 workflow
5486b23 
Restore the commit_id output
@sinsukehlab sinsukehlab mentioned this pull request Sep 12, 2023
Closed
@cmwilson21 cmwilson21 requested a review from a team September 12, 2023 21:18
@cmwilson21
Copy link
Contributor

@sinsukehlab Thanks for the PR! We'll get it reviewed soon ✨

heiskr
heiskr approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💖

@heiskr heiskr merged commit a8c8389 into skills:main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Syntax error in 2-find-commit-in-history.yml for needs.find_commit_id
3 participants
@sinsukehlab @cmwilson21 @heiskr