fix(be): make admin to get all contest submissions (#1651)

skkuding · Apr 15, 2024 · 3179115 · 3179115
1 parent ece6da8
commit 3179115
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/apps/backend/apps/client/src/submission/submission.controller.ts b/apps/backend/apps/client/src/submission/submission.controller.ts
@@ -172,6 +172,7 @@ export class ContestSubmissionController {
         problemId,
         contestId,
         userId: req.user.id,
+        isAdmin: req.user.isAdmin(),
         groupId
       })
     } catch (error) {

diff --git a/apps/backend/apps/client/src/submission/submission.service.spec.ts b/apps/backend/apps/client/src/submission/submission.service.spec.ts
@@ -422,7 +422,8 @@ describe('SubmissionService', () => {
         await service.getContestSubmissions({
           problemId: problems[0].id,
           contestId: 1,
-          userId: submissions[0].userId
+          userId: submissions[0].userId,
+          isAdmin: false
         })
       )
     })
@@ -436,7 +437,8 @@ describe('SubmissionService', () => {
         service.getContestSubmissions({
           problemId: problems[0].id,
           contestId: 1,
-          userId: submissions[0].userId
+          userId: submissions[0].userId,
+          isAdmin: false
         })
       ).to.be.rejectedWith(NotFoundException)
     })
@@ -451,7 +453,8 @@ describe('SubmissionService', () => {
         service.getContestSubmissions({
           problemId: problems[0].id,
           contestId: 1,
-          userId: submissions[0].userId
+          userId: submissions[0].userId,
+          isAdmin: false
         })
       ).to.be.rejectedWith(NotFoundException)
     })

diff --git a/apps/backend/apps/client/src/submission/submission.service.ts b/apps/backend/apps/client/src/submission/submission.service.ts
@@ -628,13 +628,15 @@ export class SubmissionService implements OnModuleInit {
     problemId,
     contestId,
     userId,
+    isAdmin,
     groupId = OPEN_SPACE_ID,
     cursor = null,
     take = 10
   }: {
     problemId: number
     contestId: number
     userId: number
+    isAdmin: boolean
     groupId?: number
     cursor?: number | null
     take?: number
@@ -666,7 +668,7 @@ export class SubmissionService implements OnModuleInit {
       where: {
         problemId,
         contestId,
-        userId
+        userId: isAdmin ? undefined : userId // Admin 계정인 경우 자신이 생성한 submission이 아니더라도 조회가 가능
       },
       select: {
         id: true,